fix(livereload): Images not loading #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ebview fix(wkwebview): Images not loading in Ionic WKWebView
When running in an emulator or in a device with the flag --livereload images were not showing.
fix(livereload): Images not loading
This was referenced Jun 19, 2018
ihadeed
requested changes
Jun 25, 2018
src/providers/image-loader.ts
Outdated
| @@ -414,12 +414,19 @@ export class ImageLoader { | |||
| * @returns {Promise<string>} Returns a promise that resolves with the local path if exists, or rejects if doesn't exist | |||
| */ | |||
| private getCachedImagePath(url: string): Promise<string> { | |||
| // Check if we're running with livereload | |||
| let _isDev: boolean = (window['IonicDevServer'] != undefined); | |||
There was a problem hiding this comment.
- If the
IonicDevServervariable is defined before the app loads, it makes more sense to make this a global variable (either a variable outside the class, or a private property of the class). This way we don't have to evaluate the expression every timegetCachedImagePathis called.
src/providers/image-loader.ts
Outdated
| return new Promise<string>((resolve, reject) => { | ||
|
|
||
| // make sure cache is ready | ||
| if (!this.isCacheReady) { | ||
| return reject(); | ||
| } | ||
|
|
||
| // if we're running with livereload, ignore cache and call the resource from it's URL | ||
| if(!!_isDev){ |
There was a problem hiding this comment.
!! is not required.. since window['IonicDevServer'] != undefined or typeof window['IonicDevServer'] !== 'undefined' will always return a boolean
|
Thanks @ihadeed , I've updated the pull following your comments. |
ihadeed
approved these changes
Jun 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detects if you're running with livereload over an emulator or device, if so then ignores cached image (not reachable) and loads from URL.