Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: fix(image-loader): Wrong path with Ionic on Android #194

Merged
merged 2 commits into from
Sep 19, 2018
Merged

WIP: fix(image-loader): Wrong path with Ionic on Android #194

merged 2 commits into from
Sep 19, 2018

Conversation

flore2003
Copy link
Contributor

The check for isWKWebView is not needed in the isIonicWKWebView getter and leads to unexpected behavior when using Ionic on Android.

Closes #183

@flore2003 flore2003 changed the title fix(image-loader): Wrong path with Ionic on Android WIP: fix(image-loader): Wrong path with Ionic on Android Sep 19, 2018
@flore2003
Copy link
Contributor Author

The link is transformed but the resulting link seems not to work either 😏

@madoBaker madoBaker merged commit d4132f1 into zyra:master Sep 19, 2018
@flore2003 flore2003 deleted the patch-1 branch September 19, 2018 21:42
@rubennavarroc
Copy link

seems to be a bug with ionic webview
it's supposed to be fixed for iOS, but not for Android

ionic-team/cordova-plugin-ionic-webview#133

@Ross-Rawlins
Copy link

Ross-Rawlins commented Sep 27, 2018

so the generate PATH is correct its the webview breaking it? We have to wait for the webview to updated? What is the working version of plugin? The only version of this component that is working for me is with the webview 1.2.1 and I would like to use the latest one so any feedback would be awesome.

@rubennavarroc
Copy link

I think there is none by now. I see the guys from ionic-webview have taken care of the ios bug but not the android one. Anyhow I don't see any performance issues by importing base64 instead of linking to the http link.

@Ross-Rawlins
Copy link

@rubennavarroc do you convert the image to base643 from what ever path you are given then use that and you say it works fine on ios and android?

@Mapiac
Copy link

Mapiac commented Mar 13, 2019

@Ross-Rawlins @rubennavarroc what was the end game with this on Android anyone know if Ionic got it dealt with?

@mrm4x
Copy link

mrm4x commented Jun 4, 2019

I had this problem again but in the end i find out that's related to the Webview package version. I upgraded to "cordova-plugin-ionic-webview": "~4.0.1" and now it works like a charm also on Android.
I hope it could be useful to someone else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not allowed to load local resource
6 participants