Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(image-loader): URLs with query params lead to broken filenames #196

Merged
merged 1 commit into from
Sep 21, 2018
Merged

fix(image-loader): URLs with query params lead to broken filenames #196

merged 1 commit into from
Sep 21, 2018

Conversation

flore2003
Copy link
Contributor

Image URLs with query params lead to broken filenames when using fileNameCachedWithExtension due to the way the file extension is calculated from the URL. This fixes the problem.

@madoBaker madoBaker merged commit d32f351 into zyra:master Sep 21, 2018
@flore2003 flore2003 deleted the patch-1 branch September 21, 2018 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flore2003 @madoBaker