Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy load fix #10

Merged
merged 4 commits into from
Sep 11, 2017
Merged

Lazy load fix #10

merged 4 commits into from
Sep 11, 2017

Conversation

jwelmac
Copy link
Contributor

@jwelmac jwelmac commented Sep 10, 2017

Allow Module loading in lazy loaded pages.
closes #9

Usage:

import { TooltipsChildModule } from 'ionic-tooltips/tooltips.child.module';
import { CommonModule } from '@angular/common';
import { HomePage } from './home';
import { NgModule } from '@angular/core';
import { IonicPageModule } from 'ionic-angular';

@NgModule({
declarations: [
HomePage,
],
imports: [
CommonModule,
IonicPageModule.forChild(HomePage),
TooltipsChildModule
],
exports: [
HomePage
]
})
export class HomePageModule {}

@ihadeed ihadeed merged commit f613824 into zyra:master Sep 11, 2017
@ihadeed
Copy link
Member

ihadeed commented Sep 11, 2017

I removed the BrowserAnimationsModule import. Users now have to import it manually into their app's main module. I noticed other libraries do this, to make sure that we always have only one instance imported.

@jwelmac
Copy link
Contributor Author

jwelmac commented Sep 11, 2017

Thats a great approach.

I recognized that even the presence of the import statement in the file throws an error even if it is not explicitly imported into your module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants