make sidebar scollable when too long #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So some browsers only showed the scroll bar when necessary before, but not all. Added a commit to fix that. |
|
After a bit more testing, I don't think this generalizes as well as I thought to cases where a scroll bar isn't needed (which is the common one). So I'll close this for now and just use this as needed for my own site - if you're interested in getting a more broadly reusable change for this issue done still let me know and I'll revisit. Thanks for your work on the theme! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #23 - I chose to go with no x overflow as I don't think it's necessary (seems to rearrange as needed already).