Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An attribute read without quotes is written without quotes even after the value has been set #565

Closed
POFerro opened this issue Aug 14, 2024 · 2 comments
Assignees

Comments

@POFerro
Copy link
Contributor

POFerro commented Aug 14, 2024

Hi @JonathanMagnan ,

I stumbled upon a situation where an attribute that is read without quotes is written without quotes even after gaining a value.
This is when the GlobalDefaultQuote type is set to initial on the document, the attribute gets this value on Value set and then writes no quotes when serializing.

I created PR #564 to correct this issue, could you please have a look?

Thanks and best regards

@JonathanMagnan JonathanMagnan self-assigned this Aug 14, 2024
@JonathanMagnan
Copy link
Member

Hello @POFerro ,

Sure, I will take a look this weekend :)

Best Regards,

Jon

@JonathanMagnan
Copy link
Member

Hello @POFerro ,

Thank you again for your contribution. Indeed, that was a good catch for this special case.

Your PR has been merged and released in the v1.11.64

Best Regards,

Jon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants