Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Adding haversine to brute force knn #3579

Merged
merged 7 commits into from
Mar 4, 2021

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Mar 3, 2021

No description provided.

@cjnolet cjnolet added feature request New feature or request 2 - In Progress Currenty a work in progress CUDA / C++ CUDA issue non-breaking Non-breaking change labels Mar 3, 2021
@cjnolet cjnolet requested a review from a team as a code owner March 3, 2021 18:59
@cjnolet cjnolet requested review from a team as code owners March 3, 2021 21:06
@github-actions github-actions bot added CMake Cython / Python Cython or Python issue labels Mar 3, 2021
@cjnolet cjnolet changed the title [WIP] Adding haversine to brute force knn [REVIEW] Adding haversine to brute force knn Mar 3, 2021
@cjnolet cjnolet added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currenty a work in progress labels Mar 3, 2021
Copy link
Member

@divyegala divyegala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Half a day to put this out, and I literally have no comments to add! Looks excellent, thanks Corey

@JohnZed
Copy link
Contributor

JohnZed commented Mar 4, 2021

@gpucibot merge

@codecov-io
Copy link

Codecov Report

Merging #3579 (e29fa13) into branch-0.19 (9fa6e17) will increase coverage by 45.58%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-0.19    #3579       +/-   ##
================================================
+ Coverage        35.24%   80.83%   +45.58%     
================================================
  Files              378      227      -151     
  Lines            26910    17737     -9173     
================================================
+ Hits              9485    14337     +4852     
+ Misses           17425     3400    -14025     
Flag Coverage Δ
dask 45.30% <0.00%> (+0.30%) ⬆️
non-dask 73.09% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/cuml/neighbors/__init__.py 100.00% <ø> (ø)
python/cuml/neighbors/nearest_neighbors.pyx 92.64% <100.00%> (+50.89%) ⬆️
python/cuml/dask/solvers/cd.py 100.00% <0.00%> (ø)
python/cuml/common/numba_utils.py 0.00% <0.00%> (ø)
python/cuml/internals/global_settings.py 100.00% <0.00%> (ø)
python/cuml/dask/preprocessing/encoders.py 100.00% <0.00%> (ø)
cuml/comm/serialize.py
cuml/preprocessing/__init__.py
cuml/_thirdparty/sklearn/utils/validation.py
cuml/preprocessing/label.py
... and 286 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fa6e17...e29fa13. Read the comment docs.

@rapids-bot rapids-bot bot merged commit a3bfb36 into rapidsai:branch-0.19 Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team CMake CUDA / C++ CUDA issue Cython / Python Cython or Python issue feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants