Skip to content

Conversation

@ryan331913
Copy link
Contributor

Hi @0010aor

This PR is related the backend testing in Github Action.

  • Change default value of AI_MODEL and AI_API_KEY (will assert error "AI models are not enabled or configured" if empty)
  • Fix coverage source from app to src

@0010aor
Copy link
Owner

0010aor commented May 2, 2025

Thank you so much for your excellent contribution!

A few suggestions:

  • Please add workflow_dispatch to the pipeline so it can be triggered manually from the GitHub Actions
  • Consider renaming the Docker Compose file to clarify that it’s intended for testing (not local development) maybe something like docker-compose.test.yaml.
  • The database volume likely isn’t needed for CI, since we don’t want to persist data between runs.
  • It would be great to add a small .md file (linked from the README) with a short explanation of how to run the pipeline locally (for example, using act).

let me know your thoughts!

Again thanks for this, these improvements are really big step. 🙌

@0010aor 0010aor linked an issue May 2, 2025 that may be closed by this pull request
@0010aor 0010aor added backend only backend issue CI/CD Issues related to CI/CD pipelines labels May 2, 2025
@ryan331913
Copy link
Contributor Author

I think that's a good idea to separate the docker compose names between development and testing.
In this case, I might move the docker compose file to backend folder, and rename by your suggestions.
Would this be more organized?

I will add the act related .md file after I study the tool, thank you

@0010aor
Copy link
Owner

0010aor commented May 2, 2025

I think that's a good idea to separate the docker compose names between development and testing. In this case, I might move the docker compose file to backend folder, and rename by your suggestions. Would this be more organized?

I will add the act related .md file after I study the tool, thank you

Yes I like it. Thanks! 🙏

@ryan331913
Copy link
Contributor Author

ryan331913 commented May 2, 2025

Hi @0010aor

I add the simple guide of how to use act locally in new folder called docs and linked in README.
Please have a look at it and let me know your suggestions, thanks!

Great job!

@0010aor 0010aor merged commit ff36748 into 0010aor:main May 4, 2025
3 checks passed
VictoriaTskhondia pushed a commit to VictoriaTskhondia/FlashNotes that referenced this pull request May 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend only backend issue CI/CD Issues related to CI/CD pipelines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CI Pipeline for Automated Backend Testing

2 participants