Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

script not add hdd to rx1214rp #288

Closed
cyonixx opened this issue May 7, 2024 · 7 comments
Closed

script not add hdd to rx1214rp #288

cyonixx opened this issue May 7, 2024 · 7 comments

Comments

@cyonixx
Copy link

cyonixx commented May 7, 2024

on my rs4021xs+ your script is not adding the MG09ACA18TE to RX1214rp db file. can you add it please?

../syno_hdd_db.sh
Synology_HDD_db v3.5.89
RS4021xs+ DSM 7.2.1-69057-3
StorageManager 1.0.0-0017

rs4021xs+_host_v7 version 8035

Running from: /volume2/BackupAllMCPs/syno_hdd_db.sh

HDD/SSD models found: 2
MG09ACA18TE,0104
MG09ACA18TE,0105

M.2 drive models found: 1
Force MP600,EGFM11.3

M.2 PCIe card models found: 1
M2D20

Expansion Unit models found: 2
RX1214rp
RX1217

Updated MG09ACA18TE in rs4021xs+_host_v7.db
Updated MG09ACA18TE in rx1217rp_v7.db
Updated MG09ACA18TE in rx1217sas_v7.db
Updated MG09ACA18TE in rx1217_v7.db
Updated MG09ACA18TE in rs4021xs+_host_v7.db
Updated MG09ACA18TE in rx1217rp_v7.db
Updated MG09ACA18TE in rx1217sas_v7.db
Updated MG09ACA18TE in rx1217_v7.db
Force MP600 already exists in rs4021xs+_host_v7.db
Force MP600 already exists in rs4021xs+_m2d20_v7.db

M2D20 NVMe already enabled for RS4021xs+
@007revad
Copy link
Owner

007revad commented May 7, 2024

What does the following command return?

find /var/lib/disk-compatibility/ -maxdepth 1 -name "rx1214rp*.db"

@cyonixx
Copy link
Author

cyonixx commented May 8, 2024

/var/lib/disk-compatibility/rx1214rp_v7.db

@007revad
Copy link
Owner

007revad commented May 8, 2024

I'll make a debug version of the script so we can see what it's doing wrong.

@007revad
Copy link
Owner

007revad commented May 8, 2024

What's happening is the script seems to only process the last expansion unit in the list.

I can reproduce the problem here so I can fix it a release new version of the script.

007revad added a commit that referenced this issue May 8, 2024
@007revad
Update syno_hdd_db.sh
d4ac47d 
v3.5.90
- Changed to enable creating storage pools/volumes on NVMe drives in a PCIe M.2 adaptor in DSM 7.2
  - Previously only supported DSM 7.2.1
- Changed to enable creating storage pools/volumes on NVMe drives in a PCIe M.2 adaptor even if PCIe M.2 adaptor not found.
  - This may allow creating NVMe volumes on 3rd party PCIe M.2 adaptors.
- Bug fix for when there's multiple expansion unit models only the last expansion unit was processed. Issue #288
- Bug fix for when there's multiple M2 adaptor card models only the last M2 card was processed. 
- Bug fix for incorrectly matching model name variations as well as the exact model name. 
  - e.g. RX1217 matched RX1217, RX1217rp and RX1217sas.
@007revad
Copy link
Owner

007revad commented May 8, 2024

Can you try this version:
https://github.com/007revad/Synology_HDD_db/releases/tag/v3.5.90-RC

@cyonixx
Copy link
Author

cyonixx commented May 10, 2024

great! it works now.

@007revad 007revad mentioned this issue May 10, 2024
Merged
@007revad
Copy link
Owner

I've just released a final 3.5.90 version. You should update to it so the script can update to, or notify you of, any future newer versions.
https://github.com/007revad/Synology_HDD_db/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@007revad @cyonixx