-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement cross compile to validate i686 in addition to x86_64 tests. #247
Conversation
345921f
to
e5c3a67
Compare
e5c3a67
to
26205c5
Compare
Thanks a lot for your PR, @simonrupf! A few ideas:
|
Sure thing, lets use this opportunity to experiment with a few things. |
df3dc77
to
19a3207
Compare
19a3207
to
ccc6cd8
Compare
Ok, so using Let me know if that is an acceptable use or if you know of any other actions we could try. |
Yes, this looks very good! Thanks a lot so far! Do you think, by the way, that the method that you used in this workflow can be applied to the |
4d01edf
to
b5a4cf0
Compare
For testing purposes this workflow triggers on every commit, but got defanged not to use secrets or publish.
b5a4cf0
to
0c834b6
Compare
I created this in a two step process, to be able to test the workflow without triggering a release. Last clean run of that test workflow can be found at: The windows gnu build still fails, due to a tool or library with the wrong version, details in the comment above the disabled target and error can be found in: One of the arm targets seems no longer supported, the error indicates:
So I added those two instead and they build successfully. |
This is very good work, @simonrupf! Thanks a lot for your dedication! |
As per discussion in #245 (comment) this change experiments with adding a matrix build for the unit tests. For now it only adds i686 to the existing x86_64 to catch out 32bit related differences. It seems to run in a similar time frame as the prior runs before this change, 1min to 1min 15s.
Changes in detail: