Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat get_or_none method #185

Merged
merged 5 commits into from
Sep 12, 2023
Merged

feat get_or_none method #185

merged 5 commits into from
Sep 12, 2023

Conversation

mishaga
Copy link
Contributor

@mishaga mishaga commented Sep 5, 2023

Closes issues #170 and #151

self.assertIsNone(obj3)

self.run_with_managers(test)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR but could you move this test to test_common.py file and rewrite in a pytest way like other ones? The file contains deprecated tests which have to be rewritten #177

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@kalombos kalombos merged commit 882c14a into 05bit:master Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants