Removed AsyncDatabase.fetch_results() + compat logic updated #233
+81
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 4, 2024
kalombos
requested changes
May 5, 2024
rudyryk
force-pushed
the
refactoring/manager-compat
branch
from
a0138ba to
06386fa
Compare
rudyryk
force-pushed
the
refactoring/database-fetch-results
branch
from
1aafc49 to
af6b109
Compare
kalombos
requested changes
May 6, 2024
kalombos
reviewed
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When proper query class is provided
AsyncDatabase.fetch_results()never gets called, so it can actually be removed.For compatibility with original peewee's queries patching logic updated in
_patch_query_with_compat_methods()to make sure we have proper methods for async results fetching etc.