Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed AsyncDatabase.fetch_results() + compat logic updated #233

Merged

Conversation

rudyryk
Copy link
Member

@rudyryk rudyryk commented May 4, 2024

When proper query class is provided AsyncDatabase.fetch_results() never gets called, so it can actually be removed.

For compatibility with original peewee's queries patching logic updated in _patch_query_with_compat_methods() to make sure we have proper methods for async results fetching etc.

@rudyryk rudyryk force-pushed the refactoring/manager-compat branch from a0138ba to 06386fa Compare May 5, 2024 17:39
@rudyryk rudyryk force-pushed the refactoring/database-fetch-results branch from 1aafc49 to af6b109 Compare May 5, 2024 17:42
@rudyryk rudyryk requested a review from kalombos May 5, 2024 18:43
@rudyryk rudyryk requested a review from kalombos May 9, 2024 15:39
@rudyryk rudyryk merged commit bd04d1c into refactoring/manager-compat May 9, 2024
@rudyryk rudyryk deleted the refactoring/database-fetch-results branch May 9, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants