Draft: add psycopg3 pool #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akerlay
commented
Sep 30, 2024
akerlay
commented
Sep 30, 2024
…emove redundant imports
kalombos
reviewed
Sep 30, 2024
kalombos
reviewed
Sep 30, 2024
spumer
reviewed
Sep 30, 2024
spumer
reviewed
Sep 30, 2024
…here psycopg is not installed
kalombos
reviewed
Oct 11, 2024
peewee_async/pool.py
Outdated
| if self.pool is None: | ||
| await self.connect() | ||
| assert self.pool is not None, "Pool is not connected" | ||
| return await self.pool.getconn() |
There was a problem hiding this comment.
Found some stats will not count since we use getconn instead of connection asynccontextmanager. https://github.com/psycopg/psycopg/blob/master/psycopg_pool/psycopg_pool/pool_async.py#L198
There was a problem hiding this comment.
I created an issue #300 No need to fix in the PR
removed 3 postfix for psycopg
kalombos
reviewed
Oct 20, 2024
kalombos
reviewed
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.