Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sound mismatch near the beginning #37

Closed
Norgus opened this issue Nov 16, 2015 · 3 comments
Closed

Sound mismatch near the beginning #37

Norgus opened this issue Nov 16, 2015 · 3 comments
Labels

Comments

@Norgus
Copy link
Contributor

Norgus commented Nov 16, 2015

Sorry if this isn't the right way to report this, but I'm not really used to using github.

In the file
onik_002.txt
line 1637 plays a sound file "s19/04/990400046" which covers not only this bit of text, but the following one too.
However, on the following bit of text, the next sound file is played on line 1644 - "s19/04/990400047" and does not match the text (and indeed is repeated a few lines of game text later)

I don't know how best to fix this.

  1. The audio file ending 46 could be split into two and assigned to each half of the gametext
    or
  2. The two prompts worth of gametext could be merged into one to match the sound

I suspect that 2 is easier but I haven't tried it yet.

ItaloKnox added a commit that referenced this issue Nov 16, 2015
@ItaloKnox ItaloKnox added the bug label Nov 16, 2015
@ItaloKnox
Copy link
Member

Thanks for reporting this. I merged both lines, but both ways are easy to do.
Do you have a save file close to this scene? I would like to see if it was really fixed.

Download the master file if you want the new script. Also don't forget to reset the compiled folders.

Edit: went to the scene by myself, it's working fine. Thanks for pointing this out!

@Norgus
Copy link
Contributor Author

Norgus commented Nov 16, 2015

Thanks for the fast response!
I have a feeling I came across something else earlier too but forgot about it.
I was planning to play through the whole thing, so I'll try to remember to make notes when I notice stuff.

If I find more than a few, I'll work out the forking and pull-requesting stuff.

@ItaloKnox
Copy link
Member

Sure, thanks for the help. You might notice some cases like this one, unfortunately many of them are unavoidable if you are a slow reader or playing on auto.
Take note of the cases that completely breaks the flow of the game, I'll take care of them (or you can pull request them, that helps a lot!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants