fix: remove broken DTX legacy beatline chips processing (0x51) #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The insertion of beatlines failed to consider non-x/4 time signature, mid-measure #BPMCHANGE, and mid-measure #DELAY. Beatline is unused in Taiko gameplay, and the wrong insertion of beatline can cause extremely long song duration, wrong retry position (when the calculated time overflows, the BPM is negative, or when the lower number of time signature is negative), and bad performance for charts containing high BPM and long time signature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The insertion of beatlines failed to consider non-x/4 time signature, mid-measure #BPMCHANGE, and mid-measure #DELAY.
Beatline is unused in Taiko gameplay,
and the wrong insertion of beatline can cause
extremely long song duration, wrong retry position (when the calculated time overflows, the BPM is negative, or when the lower number of time signature is negative), and bad performance for charts containing high BPM and long time signature.
Test Cases
Miracle 5ympho X (kirura969), chart download link is in channel description.
Intended behavior: https://youtu.be/rwArv-JyAW4
❌ Before behavior: Wrong chart length, wrong retry position.
OpenTaiko.0.6.0.23.2024-12-04.Miracle.5ympho.X.kirura969.wrong.retry.position.mp4
⭕ After behavior
OpenTaiko.PR.2024-12-04.Miracle.5ympho.X.kirura969.correct.retry.position.mp4
Benchmarks
愛歌「ネグラドルナ」(kirura969), chart download link is in channel description.
Intended behavior: https://youtu.be/2xtRk239msI (except for note count capping)
The ending part is different because the stopping effects of
#DELAYhas not been implemented in OpenTaiko.❌ Before behavior: mostly 3x fps, halt at end
OpenTaiko.0.6.0.23.2024-12-04.kirura969.-.0.01.05-0.02.22.mp4
❌ After behavior: mostly 5x fps, halt at end
※ #757 is applied here.
OpenTaiko.PR.2024-12-04.kirura969.-.0.01.05-0.02.30.mp4