Catch route parameter keywords from schema when parsing params

[jonathanlintott]

To solve issue #107

[jonathanlintott]

I'm not sure why the lint and test checks are not running.

[kemingy]

That's weird. According to the GitHub Actions setting:

spectree/.github/workflows/pythonpackage.yml

Lines 4 to 8 in d7cd12d

	pull_request:
	push:
	branches:
	- master
	- dev

, all the pull requests will trigger the lint and test.

Never mind. I can run it locally.

[kemingy]

Hi @jonathanlintott can you run the following cmd:

make lint
make test

To format the code, can run make format.

[jonathanlintott]

To format the code, can run make format.

Have run make format as requested. However it's changed many more module than this PR originally did.

[kemingy]

Have run make format as requested. However it's changed a lot more code than this PR originally did.

I think it's because you are using a different version of black.

You can create a virtualenv and run:

make install
make format
make lint
make test

[jonathanlintott]

Have run make format as requested. However it's changed a lot more code than this PR originally did.

I think it's because you are using a different version of black.

You can create a virtualenv and run:

make install
make format
make lint
make test

I'm working from a company machine so I'm limited to what packages I can access and what versions we have of them available that's passed our internal audit.

Regarding the failing falcon test, I get the same failing result on the master branch as well as this branch. I would have assumed it was a package mismatch except that it's happening on this CI as well. Maybe there's some new falcon package that's not compatible with spectree master?

[kemingy]

Regarding the failing falcon test, I get the same failing result on the master branch as well as this branch. I would have assumed it was a package mismatch except that it's happening on this CI as well. Maybe there's some new falcon package that's not compatible with spectree master?

Yeah. That's because falcon just released 3.0. I think I need to fix the test.

[kemingy]

#116 should be able to fix the falcon 3 issues. You can try to pull the latest changes.

[jonathanlintott]

#116 should be able to fix the falcon 3 issues. You can try to pull the latest changes.

Aye that all passes now. I'll wait until you merge #116 then I'll rebase this branch.

[kemingy]

Aye that all passes now. I'll wait until you merge #116 then I'll rebase this branch.

Merged

[jonathanlintott]

Would it be possible to release a v0.4.2 or v0.5.0 after this PR is merged?

[kemingy]

LGTM. Will release a new version.