Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix import statement compatibility in Falcon2 and 3 #141

Closed
wants to merge 1 commit into from
Closed

Fix import statement compatibility in Falcon2 and 3 #141

wants to merge 1 commit into from

Conversation

mortymacs
Copy link
Contributor

@mortymacs mortymacs commented Jun 2, 2021 •
edited
Loading

This is actually a hotfix of the last changes.

@kemingy
Copy link
Member

kemingy commented Jun 3, 2021

Can you provide some examples that will trigger the following exceptions:

  • falcon 2 MediaNotFoundError
  • falcon 3 HTTPUnsupportedMediaType
  • falcon 3 MediaNotFoundError

Previously, I added HTTPUnsupportedMediaType to fix the falcon 3 compatible problems in #116. I'm not sure if falcon 2 need to deal with this kind of exceptions.

@mortymacs
Copy link
Contributor Author

Can you provide some examples that will trigger the following exceptions:

  • falcon 2 MediaNotFoundError
  • falcon 3 HTTPUnsupportedMediaType
  • falcon 3 MediaNotFoundError

Previously, I added HTTPUnsupportedMediaType to fix the falcon 3 compatible problems in #116. I'm not sure if falcon 2 need to deal with this kind of exceptions.

Sure, I think I can even update tests for it but I have to check the possibility. About Falcon2, that's why I added an if/else for the MediaNotFoundError exception.

@mortymacs mortymacs mentioned this pull request Jul 13, 2021
Closed
@mortymacs
Copy link
Contributor Author

This PR is no longer needed due to this update #174

@mortymacs mortymacs closed this Oct 26, 2021
@mortymacs mortymacs deleted the falcon3-compatibility-fix branch October 26, 2021 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mortymacs @kemingy