Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop support for Falcon 2 #239

Merged
merged 2 commits into from
Jul 29, 2022
Merged

Conversation

yedpodtrzitko
Copy link
Collaborator

moreless copy-paste of my comment here: #225 (comment)

Falcon 2 was released 2019 and never got any patch above 2.0.0 (see https://pypi.org/project/falcon/#history ), so it seems unsupported anyway.

The reason why I would propse doing this is that Falcon 2 does not support form data. The pipeline in #225 fails right now because get_media() does not exist in Falcon 2, so I tried to use req.media instead, and I got the following error (with Falcon 2)

AssertionError: {"title": "Unsupported media type", "description": "multipart/form-data is an unsupported media type."}

Dropping Falcon 2 would then make implementing the form data support easier.

@yedpodtrzitko yedpodtrzitko requested a review from kemingy July 23, 2022 11:26
@yedpodtrzitko yedpodtrzitko changed the title refactoring: drop support for Falcon 2 drop support for Falcon 2 Jul 23, 2022
Copy link
Member

@kemingy kemingy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can you help to change the falcon demo in README?

Another thing related to falcon 2 is the

# used to detect falcon 3.0 request media parse error
self.FALCON_HTTP_ERROR = HTTPError
self.FALCON_MEDIA_ERROR_CODE = (HTTP_400, HTTP_415)
self.FIELD_PATTERN = _FIELD_PATTERN

README.md Outdated Show resolved Hide resolved
@yedpodtrzitko
Copy link
Collaborator Author

it's rebased now, pipeline passing

@kemingy kemingy enabled auto-merge (squash) July 29, 2022 01:11
@kemingy kemingy merged commit 69efb2e into 0b01001001:master Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants