Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update error messages #1033

Merged
merged 4 commits into from
Apr 27, 2023
Merged

update error messages #1033

merged 4 commits into from
Apr 27, 2023

Conversation

boddumanohar
Copy link
Contributor

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2023

Codecov Report

Merging #1033 (2a38919) into staging (ba3a56f) will increase coverage by 0.00%.
The diff coverage is 33.33%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff            @@
##           staging    #1033   +/-   ##
========================================
  Coverage    27.73%   27.73%           
========================================
  Files           77       77           
  Lines         8091     8094    +3     
========================================
+ Hits          2244     2245    +1     
- Misses        5556     5558    +2     
  Partials       291      291           
Flag Coverage Δ
Unit-Tests 27.73% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain.net/blobbercore/handler/file_command_upload.go 42.36% <0.00%> (-0.30%) ⬇️
...et/blobbercore/handler/object_operation_handler.go 30.89% <0.00%> (-0.04%) ⬇️
...ode/go/0chain.net/blobbercore/writemarker/mutex.go 48.10% <100.00%> (+0.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@boddumanohar boddumanohar changed the title update error message: requestTime ahead of current time update error messages Apr 15, 2023
Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterlimg peterlimg merged commit a714b73 into staging Apr 27, 2023
@peterlimg peterlimg deleted the request-time branch April 27, 2023 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants