Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage V2 #1476

Merged
merged 72 commits into from
Oct 12, 2024
Merged

Storage V2 #1476

merged 72 commits into from
Oct 12, 2024

Conversation

Hitenjain14
Copy link
Member

@Hitenjain14 Hitenjain14 commented Sep 6, 2024

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 6.69882% with 1741 lines in your changes missing coverage. Please review.

Project coverage is 13.78%. Comparing base (e5018a7) to head (8d63a5c).
Report is 119 commits behind head on staging.

Files with missing lines Patch % Lines
...et/blobbercore/handler/object_operation_handler.go 12.44% 566 Missing and 25 partials ⚠️
...ain.net/blobbercore/allocation/allocationchange.go 0.00% 162 Missing ⚠️
code/go/0chain.net/blobbercore/reference/ref.go 0.75% 131 Missing ⚠️
.../0chain.net/blobbercore/handler/storage_handler.go 1.00% 99 Missing ⚠️
...ode/go/0chain.net/blobbercore/filestore/storage.go 8.33% 84 Missing and 4 partials ⚠️
....net/blobbercore/allocation/file_changer_update.go 0.00% 82 Missing ⚠️
...ain.net/blobbercore/allocation/renamefilechange.go 0.00% 79 Missing ⚠️
...chain.net/blobbercore/allocation/movefilechange.go 3.75% 77 Missing ⚠️
....net/blobbercore/allocation/file_changer_upload.go 0.00% 75 Missing ⚠️
...chain.net/blobbercore/allocation/copyfilechange.go 4.10% 70 Missing ⚠️
... and 22 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1476      +/-   ##
===========================================
- Coverage    14.88%   13.78%   -1.11%     
===========================================
  Files          179      180       +1     
  Lines        20222    21851    +1629     
===========================================
+ Hits          3011     3012       +1     
- Misses       16839    18463    +1624     
- Partials       372      376       +4     
Flag Coverage Δ
Unit-Tests 13.78% <6.69%> (-1.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hitenjain14 Hitenjain14 changed the base branch from staging to sprint-1.18 October 10, 2024 17:04
@Hitenjain14 Hitenjain14 mentioned this pull request Oct 10, 2024
3 tasks
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov marked this pull request as ready for review October 12, 2024 19:50
@dabasov dabasov merged commit 1a881b8 into sprint-1.18 Oct 12, 2024
4 of 6 checks passed
@dabasov dabasov deleted the feat/storage-v2 branch October 12, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants