Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix json tag issue #325

Merged
merged 1 commit into from
Sep 3, 2021
Merged

Fix json tag issue #325

merged 1 commit into from
Sep 3, 2021

Conversation

lpoli
Copy link
Contributor

@lpoli lpoli commented Aug 28, 2021

The json tag that had been used broke old api that used default value(struct field).
To fix this issue New struct(as Gorm smart select field) is created leaving Ref struct as it is.

@cnlangzi
Copy link
Contributor

@lpoli and me had some discussion about this feature. I will refactor some code instead of code review first.

Copy link
Contributor

@cnlangzi cnlangzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's merged it to fix tag issues first. we will raise new issue to discuss how to implement api with new code style.

@service-0chain service-0chain merged commit 6d0abe2 into master Sep 3, 2021
@lpoli lpoli deleted the bug/ref-json-tag branch September 6, 2021 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants