-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit the combined directories and files per allocation #676
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report
@@ Coverage Diff @@
## staging #676 +/- ##
===========================================
+ Coverage 22.02% 23.91% +1.88%
===========================================
Files 69 69
Lines 7933 7967 +34
===========================================
+ Hits 1747 1905 +158
+ Misses 5924 5779 -145
- Partials 262 283 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Manual system tests [cancelled] with the following config
|
Changes
Add new
max_dirs_files
config (default 1000) to limit the number of files and directories per allocation.The check is applied on file actions that will create new file such as
The check occurs first before any file ref changes. It is not too restrictive in a sense that it will not consider how many new refs a file action will make. As long as current total combined files and dirs are below limit, the whole file action will be allowed to go.
Fixes
Fixes #639
Tests
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):