-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/heathcheck #718
Fix/heathcheck #718
Conversation
Codecov Report
@@ Coverage Diff @@
## staging #718 +/- ##
===========================================
+ Coverage 24.06% 24.18% +0.11%
===========================================
Files 69 69
Lines 7957 7907 -50
===========================================
- Hits 1915 1912 -3
+ Misses 5757 5710 -47
Partials 285 285
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
code/go/0chain.net/blobber/worker.go
Outdated
} | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's better to avoid if-then-else and replace themwith if-not-then
it's easy to read something like
if err != nil {
//some code
return
}
//other code
then
if err == nil {
//some code
} else {
//other code
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Changes
Fixes
HealthCheck
sc seems be broken #708: send healtcheck in backgroundTests
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):