Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(challenge): improved logging #769

Merged
merged 5 commits into from
Jul 31, 2022
Merged

Conversation

cnlangzi
Copy link
Contributor

Changes

Fixes

  • improved logging for challenge.

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@cnlangzi cnlangzi requested a review from peterlimg July 29, 2022 03:30
@cnlangzi cnlangzi requested a review from ssardana08 July 29, 2022 09:11
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2022

Codecov Report

Merging #769 (d99a72e) into staging (fe23ab8) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           staging     #769      +/-   ##
===========================================
+ Coverage    24.37%   24.41%   +0.03%     
===========================================
  Files           77       77              
  Lines         7818     7826       +8     
===========================================
+ Hits          1906     1911       +5     
- Misses        5646     5648       +2     
- Partials       266      267       +1     
Flag Coverage Δ
Unit-Tests 24.41% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et/blobbercore/handler/object_operation_handler.go 33.05% <0.00%> (+0.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Contributor

@ssardana08 ssardana08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cnlangzi cnlangzi merged commit 3d22da9 into staging Jul 31, 2022
@cnlangzi cnlangzi deleted the fix/improve_logging_challenge branch July 31, 2022 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants