Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/challenge issue #774

Merged
merged 28 commits into from
Aug 5, 2022
Merged

Fix/challenge issue #774

merged 28 commits into from
Aug 5, 2022

Conversation

lpoli
Copy link
Contributor

@lpoli lpoli commented Jul 31, 2022

Fixes

  1. Added lock between object path calculation and writemarker commit in handler.CommitWrite function
  2. Fix database connection leakage
  3. Use goroutines to send request to validators
  4. Allow blank allocation to be valid.

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2022

Codecov Report

Merging #774 (907f825) into staging (a0f9f20) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

@@             Coverage Diff             @@
##           staging     #774      +/-   ##
===========================================
- Coverage    24.40%   24.40%   -0.01%     
===========================================
  Files           77       77              
  Lines         7829     7830       +1     
===========================================
  Hits          1911     1911              
- Misses        5651     5652       +1     
  Partials       267      267              
Flag Coverage Δ
Unit-Tests 24.40% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...de/go/0chain.net/blobbercore/allocation/workers.go 0.00% <0.00%> (ø)
...et/blobbercore/handler/object_operation_handler.go 33.05% <ø> (ø)
code/go/0chain.net/blobbercore/reference/ref.go 0.00% <ø> (ø)
code/go/0chain.net/validatorcore/storage/models.go 65.67% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lpoli lpoli requested a review from peterlimg August 1, 2022 07:02
@lpoli lpoli marked this pull request as ready for review August 1, 2022 07:03
@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain staging
blobber fix/challenge-issue
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain staging
blobber fix/challenge-issue
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@lpoli lpoli requested review from cnlangzi and ssardana08 August 2, 2022 17:22
@lpoli lpoli requested a review from ssardana08 August 3, 2022 11:47
@lpoli lpoli requested a review from peterlimg August 3, 2022 15:59
Copy link
Contributor

@cnlangzi cnlangzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lpoli lpoli requested a review from cnlangzi August 4, 2022 03:22
@lpoli lpoli requested a review from ssardana08 August 4, 2022 09:24
Copy link
Contributor

@ssardana08 ssardana08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lpoli lpoli dismissed cnlangzi’s stale review August 4, 2022 11:33

The problem does not exist

@lpoli lpoli dismissed peterlimg’s stale review August 5, 2022 03:18

Requested changes does not seem necessary

@lpoli lpoli merged commit 1c17cdd into staging Aug 5, 2022
@lpoli lpoli deleted the fix/challenge-issue branch August 5, 2022 04:28
@lpoli lpoli restored the fix/challenge-issue branch March 7, 2023 08:27
@lpoli lpoli deleted the fix/challenge-issue branch March 7, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants