Livestream tests

[Kishan-Dhakan]

• revert actions back to master after actions PR approved
  Streaming upload coverage, cases:
• Uploading youtube feed to allocation should work
• upload from feed with delay flag must work
• Upload from feed with a different chunksize must work
• Uploading local webcam feed to allocation should work
• Uploading local webcam feed to allocation with delay specified should work
• Upload local webcam feed with a different chunksize must work
• Uploading youtube feed with negative delay should fail
• Upload from feed with a negative chunksize should fail
• Uploading local webcam feed with negative delay should fail
• Upload from feed with a negative chunksize should fail

FIXMEs found:

• ceil(size/chunksize) is not equalling numblocks when chunksize is user-specified (it should be)
• negative chunksize is not throwing any error but instead starts uploading (it shouldn't)

[mohsenno1]

Great work. Look ok to me.

[mohsenno1]

Do we need to return it back to 'master'?

[stewartie4]

good point, is there an actions PR?

[Kishan-Dhakan]

Yep! Just raised a PR on actions repo, once that is merged I'll make a commit to revert this so it gets tested again before merge👍

[stewartie4]

@Kishan-Dhakan like you mentioned, these tests are hanging again - is there any logging we can add to debug why this is happening? We can't merge with this inconsistency as

1. there may be a code issue
2. we cant have everyone's CI hanging :(

[Kishan-Dhakan]

@Kishan-Dhakan like you mentioned, these tests are hanging again - is there any logging we can add to debug why this is happening? We can't merge with this inconsistency as

1. there may be a code issue

2. we cant have everyone's CI hanging :(

Yes, definitely we can't merge this in it's current state :( I'm certain this is caused by child processes created by this tests (ffmpeg), which is a known issue in go. But I have set a pgid which should technically kill the child processes as well (confirmed on both win and ubuntu local machines thanks to @mohsenno1). I'm trying a few more things, will post an update by today