Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New collect reward command #102

Merged
merged 40 commits into from
May 17, 2022
Merged

New collect reward command #102

merged 40 commits into from
May 17, 2022

Conversation

Sriep
Copy link
Contributor

@Sriep Sriep commented Mar 14, 2022 •
edited
Loading

A brief description of the changes in this PR:

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

This was referenced Mar 14, 2022
Closed
Merged
Merged
Merged
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests mn-sps
gosdk miner-rewards
zboxcli staging
zwalletcli collect_rewards
0chain miner-rewards
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@Sriep Sriep mentioned this pull request Mar 14, 2022
Merged
3 tasks
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests mn-sps
gosdk miner-rewards
zboxcli collect_sc
zwalletcli collect_rewards
0chain miner-rewards
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

dabasov and others added 22 commits March 14, 2022 16:19
@dabasov
merged staging
a9c60f7
@dabasov
Merge remote-tracking branch 'origin/staging' into staging
3e85b40 
# Conflicts:
#	go.mod
#	go.sum
@dabasov
merged staging
7757fb8
@Sriep
collect reward
5c81985
@Sriep
default
2b4d631
@dabasov
merged staging
46295b4
@dabasov
merged staging
38d460f
@dabasov
Merge remote-tracking branch 'origin/staging' into staging
11c9b3c
@Sriep
provider_type
cccf867
@Sriep
go mod update
a66261a
@Sriep
go mod update
174a5d4
@Sriep
Merge branch 'staging' into collect_rewards
f44df7d
@Sriep
go mod update
d6e9e92
@Sriep
go mod update
5781ced
@Sriep
go mod update
4136a54
@Sriep
go mod update
8fb0a69
@Sriep
Merge branch 'staging' into collect_rewards
50e5a46
@dabasov
Merge remote-tracking branch 'origin/staging' into staging
9b5e4cb 
# Conflicts:
#	go.mod
#	go.sum
@dabasov
Merge remote-tracking branch 'origin/staging' into staging
46013be
@Sriep
go mod update
986b299
@Sriep
go mod update
8f666d9
@Sriep
Merge branch 'staging' into collect_rewards
8863e59
@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests mn-sps
gosdk miner-rewards
zboxcli collect_sc
zwalletcli collect_rewards
0chain miner-rewards
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests mn-sps
gosdk NOT OVERRIDDEN
zboxcli collect_sc
zwalletcli collect_rewards
0chain miner-rewards
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli collect_sc
zwalletcli collect_rewards
0chain miner-rewards
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests mn-sps
gosdk NOT OVERRIDDEN
zboxcli collect_sc
zwalletcli collect_rewards
0chain miner-rewards
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@dabasov dabasov self-requested a review May 17, 2022 11:14
dabasov
dabasov approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped yes
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli collect_rewards
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@dabasov dabasov merged commit 4400bfe into staging May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabasov dabasov dabasov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sriep @service-0chain @dabasov