Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add URL argument to bridge-auth-config-update command #174

Merged
merged 2 commits into from
Sep 29, 2022

Conversation

uneet7
Copy link
Contributor

@uneet7 uneet7 commented Sep 4, 2022

A brief description of the changes in this PR:
PR adds URL argument to bridge-auth-config-update, which is further passed to update-authorizer-config txn type in 0Chain.
Reference Issue: 0chain/0chain#1625
Fixes: #173

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@uneet7 uneet7 force-pushed the feat/add-url-authorizer-update branch 2 times, most recently from 8603db1 to 787a9a8 Compare September 6, 2022 13:46
@uneet7 uneet7 requested a review from dabasov September 6, 2022 14:11
Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@uneet7 uneet7 force-pushed the feat/add-url-authorizer-update branch from 787a9a8 to 762348d Compare September 28, 2022 14:27
@dabasov dabasov merged commit aff8456 into staging Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new property - AuthorizerURL - to command 'update authorizer config'
3 participants