Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes conforming to https://github.com/0chain/gosdk/pull/794 #211

Merged
merged 3 commits into from
Mar 1, 2023

Conversation

aniketsingh03
Copy link
Contributor

A brief description of the changes in this PR:

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli fix-rounding-off-for-balance
zwalletcli fix-rounding-off-for-balance
0chain staging
blobber staging
authorizer staging
0box fix-rounding-off-for-balance
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [cancelled] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli fix-rounding-off-for-balance
zwalletcli fix-rounding-off-for-balance
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli fix-rounding-off-for-balance
zwalletcli fix-rounding-off-for-balance
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli fix-rounding-off-for-balance
zwalletcli fix-rounding-off-for-balance
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk fix-rounding-off-for-balance
zboxcli fix-rounding-off-for-balance
zwalletcli fix-rounding-off-for-balance
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterlimg
Copy link
Member

@aniketsingh03 please resolve the conflicts

@aniketsingh03 aniketsingh03 force-pushed the fix-rounding-off-for-balance branch from ae395f2 to c0e02f5 Compare February 27, 2023 13:40
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk staging
zboxcli fix-rounding-off-for-balance
zwalletcli fix-rounding-off-for-balance
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests enhancement/modify-wm-for-gdpr
gosdk enhancement/modify-wm-for-gdpr
zboxcli enhancement/modify-wm-for-gdpr
zwalletcli fix-rounding-off-for-balance
0chain enhancement/modify-wm-for-gdpr
blobber modify-wm-for-gdpr
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@aniketsingh03 aniketsingh03 force-pushed the fix-rounding-off-for-balance branch from c0e02f5 to 3e1838c Compare March 1, 2023 09:54
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli fix-rounding-off-for-balance
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped TRUE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli fix-rounding-off-for-balance
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests skip-bucket-test
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli fix-rounding-off-for-balance
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@Kishan-Dhakan Kishan-Dhakan merged commit 8be8f67 into staging Mar 1, 2023
@Kishan-Dhakan Kishan-Dhakan deleted the fix-rounding-off-for-balance branch March 1, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flakiness in bl-update
5 participants