Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(conf):#34 refactor config/network pasring with conf package #36

Closed
wants to merge 5 commits into from
Closed

fix(conf):#34 refactor config/network pasring with conf package #36

wants to merge 5 commits into from

Conversation

cnlangzi
Copy link
Contributor

fixed #34 but waiting for 0chain/gosdk#199 merged first

@cnlangzi cnlangzi marked this pull request as draft August 14, 2021 11:28
@Sriep Sriep mentioned this pull request Aug 15, 2021
Merged
@cnlangzi cnlangzi marked this pull request as ready for review August 16, 2021 10:56
@cnlangzi
Copy link
Contributor Author

blocked by #38. waiting for @Sriep to fix it.

@cnlangzi cnlangzi requested a review from moldis August 22, 2021 02:46
@cnlangzi cnlangzi marked this pull request as draft August 22, 2021 02:46
@cnlangzi
Copy link
Contributor Author

waiting for 0chain/gosdk#217 merged first.

@cnlangzi
Copy link
Contributor Author

close it . because there is not anything to change.

@cnlangzi cnlangzi closed this Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moldis moldis Awaiting requested review from moldis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor config.yaml/network.yaml parser with gosdk/zboxcore/con
1 participant
@cnlangzi