Skip to content

Commit

Permalink
powerpc/xmon: Enable disassembly files (compilation changes)
Browse files Browse the repository at this point in the history
After updating ppc-dis.c, ppc-opc.c and ppc.h the following changes were
made to enable compilation and working of xmon:

  1.  Remove all disassembler_info
  2.  Use xmon's printf/print_address to output data and addresses
      respectively.
  3.  All bfd_* types and casts have been removed.
  4.  Optimizations related to opcd_indices have been removed.
  5.  The dialect is set based on cpu features.
  6.  PPC_OPCODE_CLASSIC is no longer supported in the new
      disassembler.
  7.  VLE opcode parsing and printing has been stripped.
  8.  Coding style conventions used for those routines has
      been retained and it does not match our CodingStyle.
  9.  The highest supported dialect is POWER9.
  10. Defined ATTRIBUTE_UNUSED in ppc-dis.c.
  11. Defined _(x) in ppc-dis.c.

Finally, we remove the dependency on BROKEN so that XMON_DISASSEMBLY can
be enabled again.

Signed-off-by: Balbir Singh <bsingharora@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
  • Loading branch information
bsingharora authored and mpe committed Feb 15, 2017
1 parent 08d96e0 commit 5b10278
Show file tree
Hide file tree
Showing 4 changed files with 60 additions and 547 deletions.
1 change: 0 additions & 1 deletion arch/powerpc/Kconfig.debug
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ config XMON_DEFAULT
config XMON_DISASSEMBLY
bool "Include disassembly support in xmon"
depends on XMON
depends on BROKEN
default y
help
Include support for disassembling in xmon. You probably want
Expand Down
Loading

0 comments on commit 5b10278

Please sign in to comment.