Skip to content

Commit

Permalink
sysctl-handle-error-writing-uint_max-to-u32-fields-checkpatch-fixes
Browse files Browse the repository at this point in the history
WARNING: please, no spaces at the start of a line
torvalds#101: FILE: kernel/sysctl.c:2297:
+    return do_proc_dointvec(table,write,buffer,lenp,ppos,$

ERROR: space required after that ',' (ctx:VxV)
torvalds#101: FILE: kernel/sysctl.c:2297:
+    return do_proc_dointvec(table,write,buffer,lenp,ppos,
                                  ^

ERROR: space required after that ',' (ctx:VxV)
torvalds#101: FILE: kernel/sysctl.c:2297:
+    return do_proc_dointvec(table,write,buffer,lenp,ppos,
                                        ^

ERROR: space required after that ',' (ctx:VxV)
torvalds#101: FILE: kernel/sysctl.c:2297:
+    return do_proc_dointvec(table,write,buffer,lenp,ppos,
                                               ^

ERROR: space required after that ',' (ctx:VxV)
torvalds#101: FILE: kernel/sysctl.c:2297:
+    return do_proc_dointvec(table,write,buffer,lenp,ppos,
                                                    ^

WARNING: ENOSYS means 'invalid syscall nr' and nothing else
torvalds#115: FILE: kernel/sysctl.c:2899:
+	return -ENOSYS;

total: 4 errors, 2 warnings, 74 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

./patches/sysctl-handle-error-writing-uint_max-to-u32-fields.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
  • Loading branch information
akpm00 authored and hnaz committed Aug 23, 2016
1 parent 786e377 commit 5d72b02
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions kernel/sysctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -2274,8 +2274,7 @@ static int do_proc_dointvec(struct ctl_table *table, int write,
int proc_dointvec(struct ctl_table *table, int write,
void __user *buffer, size_t *lenp, loff_t *ppos)
{
return do_proc_dointvec(table,write,buffer,lenp,ppos,
NULL,NULL);
return do_proc_dointvec(table, write, buffer, lenp, ppos, NULL, NULL);
}

/**
Expand All @@ -2294,7 +2293,7 @@ int proc_dointvec(struct ctl_table *table, int write,
int proc_douintvec(struct ctl_table *table, int write,
void __user *buffer, size_t *lenp, loff_t *ppos)
{
return do_proc_dointvec(table,write,buffer,lenp,ppos,
return do_proc_dointvec(table, write, buffer, lenp, ppos,
do_proc_douintvec_conv, NULL);
}

Expand Down

0 comments on commit 5d72b02

Please sign in to comment.