Skip to content

Commit

Permalink
relay-use-irq_work-instead-of-plain-timer-for-deferred-wakeup-checkpa…
Browse files Browse the repository at this point in the history
…tch-fixes

ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0123456789ab ("commit description")'
torvalds#12:
	commit 7c9cb38

WARNING: line over 80 characters
torvalds#87: FILE: kernel/relay.c:337:
+	struct rchan_buf *buf = container_of(work, struct rchan_buf, wakeup_work);

WARNING: waitqueue_active without comment
torvalds#119: FILE: kernel/relay.c:772:
+		if (waitqueue_active(&buf->read_wait)) {

total: 1 errors, 2 warnings, 70 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

./patches/relay-use-irq_work-instead-of-plain-timer-for-deferred-wakeup.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Akash Goel <akash.goel@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
  • Loading branch information
akpm00 authored and sfrothwell committed Sep 29, 2016
1 parent e050b17 commit a3d3651
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion kernel/relay.c
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,9 @@ static struct rchan_callbacks default_channel_callbacks = {
*/
static void wakeup_readers(struct irq_work *work)
{
struct rchan_buf *buf = container_of(work, struct rchan_buf, wakeup_work);
struct rchan_buf *buf;

buf = container_of(work, struct rchan_buf, wakeup_work);
wake_up_interruptible(&buf->read_wait);
}

Expand Down

0 comments on commit a3d3651

Please sign in to comment.