fix: off-by-one error in token range (regression in #15). #244
Conversation
🦋 Changeset detectedLatest commit: 8f3b6cd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -9,5 +9,11 @@ const PostsQuery = gql` | |||
| } | |||
| `; | |||
|
|
|||
| const Regression190 = gql` | |||
There was a problem hiding this comment.
Does this also fail for graphql() function invocations?
There was a problem hiding this comment.
It does, yeah. Want me to add that to the fixture as well? I pushed a fix btw!
There was a problem hiding this comment.
Would love a fixture in the tada one as we're slowly moving more towards the function invocation
There was a problem hiding this comment.
Would love a fixture in the tada one as we're slowly moving more towards the function invocation
Sure! One sec
Should consistently use `stream.getStartOfToken() + 1`. Added some e2e tests to ensure that the regression in 0no-co#15 is resolved without regressing 0no-co#190.
llllvvuu
force-pushed
the
test/edge_cases
branch
from
c57c229 to
c16333a
Compare
llllvvuu
changed the title
| server.send({ | ||
| seq: 9, | ||
| type: 'request', | ||
| command: 'quickinfo', | ||
| arguments: { | ||
| file: testFile, | ||
| line: 5, | ||
| offset: 7, |
There was a problem hiding this comment.
I assume 7 still works, just clarifying
There was a problem hiding this comment.
It does, yeah, I just changed it to make it a tricker case
|
Changeset added 👍 |
Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
Should consistently use
stream.getStartOfToken() + 1. Added some e2e tests to ensure that the regression in #15 is resolved without regressing #190.