feat: add bail when we return a property from a function #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0868d6c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
commented
Mar 8, 2024
| @@ -123,7 +124,8 @@ const crawlScope = ( | |||
| originalWip: Array<string>, | |||
| allFields: Array<string>, | |||
| source: ts.SourceFile, | |||
| info: ts.server.PluginCreateInfo | |||
| info: ts.server.PluginCreateInfo, | |||
| inArrayMethod: boolean | |||
There was a problem hiding this comment.
We need a bail when we are in one of our known array methods so we can still support cases like the following https://github.com/0no-co/GraphQLSP/blob/main/packages/example-tada/src/index.tsx#L47-L50
kitten
approved these changes
Mar 9, 2024
JoviDeCroock
commented
Mar 9, 2024
JoviDeCroock
force-pushed
the
bail-for-function-return
branch
3 times, most recently
from
284ab88 to
0868d6c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we see issues when a user does
We could have built a workaround to know about memoization functions but that didn't seem like a good solution, instead we'll consider this our first "bail" scenario where we will mark the subtree of
pokemonsas used.