Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tag stringification example #99

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

AndreasHaaversen
Copy link
Contributor

Whilst setting up SSR for our app, I discovered a slight error in the example code for meta tag stringification. The extra set of brackets means that the inner reduce call never returns anything, just undefined. Removing the extra brackets makes the stringification work like a charm 🙌

Also, thanks so much for a great library! This will probably end up replacing our current rig with react-helmet-async.

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2023

⚠️ No Changeset found

Latest commit: bd3d0d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JoviDeCroock
Copy link
Member

Thank you!

@JoviDeCroock JoviDeCroock merged commit 87f5cdf into 0no-co:main Oct 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants