Make dumps of type CompleteMemoryDump trust TotalNumberOfPages header field instead of just MetadataSize
#28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugsy
changed the title
CompleteMemoryDump trust FullRdmpHeader.TotalNumberOfPages instead of just FullRdmpHeader.Hdr.MetadataSizeCompleteMemoryDump trust TotalNumberOfPages header field instead of just MetadataSize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #27
When parsing a
DumpType_t::CompleteMemoryDumptype of dump, it seems that the fieldMetadataSizefield from the RdmpHeader can exceed the actual number ofPfnRangeclass entries declared. Since we properly check bounds, it will result in a failure.This PR adds a extra check only for
CompleteMemoryDumpto enforce a strict check of the current number of pages declared and stop parsing when the expected number of pages (declared inFullRdmpHeader.TotalNumberOfPages) is reached.