Python3 bindings and get virtual page API #3

masthoon · 2020-07-19T21:35:03Z

Hi,

This PR adds Python 3 bindings (tested on Python 3.6 64 bits ; require some modification for 3.8) and some new API:

GetDirectoryTableBase
TranslateVirtualToPhysical
GetVirtualPage

WIP: Python38, auto tests of Python bindings, appveyor+travis build.

src/lib/kdmp-parser.cc

src/python/CMakeLists.txt

src/lib/kdmp-parser.cc

src/python/python-kdmp.h

0vercl0k

Cool, I dropped a few comments

src/python/CMakeLists.txt

masthoon · 2020-07-21T06:21:31Z

YO
Ok it has been tested for py36/37/38 on Windows but the AppVeyor and Travis integration only use Python 3.6 to make it easier. Small python test have been integrated to --run-tests (see Python tests: All good!).

No issue with AppVeyor build.
Travis doesn't seem to have 32 bits Python installed by default, so the py3 bindings won't compile on X86 build:
Python 3.6 development library not found. Also I didn't implement the tests on it builder.py

0vercl0k

All right did another round of comments - it's pretty cool. I need to try to make it work on my laptop now, let's see how this goes!

src/lib/kdmp-parser.cc

src/lib/kdmp-parser.h

builder.py

src/lib/kdmp-parser.cc

This PR separates the testing into a CMake target to allow #3 to work properly with various flavor of Python for the extension. On top of that, it moves off the Linux CI to Github actions (Windows will follow).

masthoon · 2020-07-27T05:14:57Z

Most comments fixed.
Only missing 32 bits Python tests on Linux (how to install py32 and debug libs?).

0vercl0k

Cool - well I guess we can leave out Linux 32bits testing as I'm not sure how to handle it; sounds like both CMake and Python are making this very tedious.

Might also be worth to update the README?

Cheers

src/lib/kdmp-parser.cc

src/python/CMakeLists.txt

src/python/python-kdmp.cc

src/tests/tests.py

.github/workflows/kdmp-parser.yml

masthoon · 2020-08-10T08:59:49Z

So I squashed all the commits into 1.
I added GetBugCheckParameters API to retrieve the bugcheck code and parameters.

Regarding the automated tests on Github:

No tests for GetBugCheckParameters (it works locally :D)
Linux 64 bits release and debug PASSED
Linux 32 bits SKIPPED because no 32 bits python executable found
Windows 32/64 release PASSED
Windows 32/64 debug SKIPPED because debug libs not installed (Add options for Python with Precompiled stdlib and debug binaries actions/setup-python#86) (it works locally too :D)

Please run clang-format if someday you accept the PR.
Let me know if you need more changes.

0vercl0k · 2020-08-10T23:55:26Z

🎉