-
-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support build on arm64 hosts (Apple M1) #44
Conversation
- add `ARCH_ARM64` macro - use `CMAKE_HOST_SYSTEM_PROCESSOR` to detect host architecture
Awesome! Do you happen to know the various different possible value for |
Cmake's docs says that it use Inside uname it's using glibc In init_uts_ns, the So here's the list: (even though I cannot assure whether I'm right or not..lol)
|
I'm curious is there any dependency that forces you to limit the host architecture? |
Awesome! I don't think so at least for little endian architectures. I think this looks good, thank you for sending this out 🙏🏽 |
I think I'm more comfortable failing the build if this is an environment
that I haven't tried / hasn't been tried. Is there a relevant architecture
/ platform that is big that you think I am missing?
Cheers
…On Tue, May 10, 2022 at 8:34 AM HexRabbit ***@***.***> wrote:
@0vercl0k <https://github.com/0vercl0k> if we check the endianness first,
maybe we could take this out?
https://github.com/0vercl0k/rp/blob/7a2ffb789c0bf8803b31840304bc66768f56e6cf/src/rp/platform.h#L11
—
Reply to this email directly, view it on GitHub
<#44 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALIOROVA7XGAKR67W5HAJDVJJ6ZVANCNFSM5VKBOUUQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Yeah, you are right, without testing it could lead to bugs. |
ARCH_ARM64
macroCMAKE_HOST_SYSTEM_PROCESSOR
to detect host architecture