-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for generating Tenet traces with bochs backend #12
Conversation
This is dope! I'll review this this weekend 🙏🏽 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All right, dropped the first round of comments; mostly nits.
All right I've fixed a bunch of stuff and it's now in a good state I think - let me know if I've messed up anything up! I've also attached a sample trace file for you to have a look if it looks fine 😀 Cheers |
I've also found a bug - basically if a breakpoint would change [update] Ok after talking with @yrp604 this logic is still flawed - if the instruction generates a page-faults we end up in the same scenario. Cheers |
All right - I've moved the logic in the Cheers |
This PR adds experimental support for generating Tenet traces with the bochs backend through wtf.
PS: I also dropped your single use of
std:rotr
as that is only supported in C++20 which was causing the build to fail on VS 2019.