-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Big list update #122
Big list update #122
Conversation
Added a bunch of packages from Oneplus 3/3T and Oneplus 9. Added a bunch of descriptions for packages already in the list. Corrected some erroneous descriptions. Shortened some descriptions and corrected some grammar.
Wow! Thanks you very much for this insane contribution! ❤️ I really appreciate the highlight but I will still skim trough all the changes. I have the feeling that I will learn a lot. EDIT: Thanks you again for taking the time to correct my many grammar mistakes (English is not my first language and I didn't spend a lot time to proofread) and fix the problems with converting the bash array lists to JSON. Scrapping the documentation has been a bit laborious. Some packages have disappeared and some descriptions have been associated with the wrong package. I've tried to fix the major problems but I see there are still some... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Phew! I finally read through all your changes. That's terrific! Amazing work!
Here is a overall summary on what I don't necessarily agree:
- Putting all overlay in the
Expert
list seems excessive to me. I think you're right to be a bit more cautious than me with overlays but if we put some packages in theRecommended
list, there is no point letting the associated overlay inExpert
list. - I find you a bit too cautious for some packages :)
I changed back some removal recommendation that I clearly disagree with but I'm still open to discussion :) The |
Part of the issue is that I don't know how important most theme packages are. Some theming systems are deeply integrated with phone systems, so there could be issues. I didn't feel the need to attempt disabling theme packages because they never execute on their own, I assume the theme manager just uses them for look-up. I also didn't have access to the packages I'm guessing are themes from other OEMs. So I played it safe and put them all in Expert. (more below)
Hehe, maybe 😅
Themes are commonly used and widespread functionality, so they fit the definition of "Expert". But I guess the argument could be made that they also fit Advanced. Edit: Additionally. It's per the "apps that aren't easily enabled/installed through Settings/Google Play" that I put a couple of calculator, recorder and similar apps in advanced. I did this as more of a blanket change to all I found (Ctrl+F), because that was the case with some Oneplus apps that don't have frivolous permissions and aren't functionally terrible. If you know of any with sneaky permissions just go ahead and move em' to Recommended. But I think it would be a disservice to use Recommended for apps that don't have sneaky permissions and never run in the background, especially if they are easily uninstalled/disabled from within the phone itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few things, aside from the larger less obvious discussion on how to categorize themes.
Additionally, on the theming categorization discussion: |
Android auto is being discontinued anyhow: https://www.androidcentral.com/google-assistant-driving-mode-replacing-android-auto-phones-are-cars-next |
I think we need to be consistent and the definition of each category is something I should have done. I appreciate the initiative!
In absolute terms, I agree. If someone want to keep an app in this category, it is better from a privacy and security point of view to uninstall the system app and install the user app version from the Play Store. But in practice, the lambda UAD user will removed all the apps from the UAD will remove all the user data associated to the app so there can be data loss. We need to be careful.
Initially, I've used this category for packages that I would like to put in
I agree. I'll add that removing packages in this category should not bootloop the device but but we can't guarantee it.
This category exists for documentation purpose. Removing any of those packages presents a very high risk of bootlooping the device.
I kind of agree. I like minimalism and I often put packages in the The thing with themes is that I find theme manager apps a bit too invasive (e.g Samsung Theme Manager) that why However, I agree, given the theming issues people reported that we need to be careful. |
- com.android.bluetoothmidiservice [Advanced -> Recommended] - com.android.email.partnerprovider.overlay [Aosp -> Oem] - Improve documentation for `com.google.ar.core`, `com.google.android.feedback` and `com.google.android.gms.policy_sidecar_aps`
- `com.evenwell.bokeheditor.overlay.base.s600ww` [Recommended -> Advanced] - `com.google.android.overlay.modules.modulemetadata.forframework` [Aosp -> Oem] - Fix typo in `com.evenwell.dataagent.overlay.base.s600id`
Yeah, that makes sense. As long as they don't run in the background (without user input) or have sneaky permissions there's no need to put them in Recommended.
I'd say "nothing important to the basic operation of the operating system" covers the "no bootloop"-part. You want a "No guarantees" in addition to that?
Yeah, but if you think about it, don't they need to be pretty "invasive" to apply themes to system packages? As for the theme packages themselves: if an OEM uses package-specific overlays as theming system (like Oneplus, Nokia and probably more) I think these should all be in Expert, regardless of what the package they theme is categorized as, because they're a part of the theming system, not the base package. And while I haven't tested anything but Oneplus' theming system, the package-specific overlay packages never execute on their own and have zero permissions, making them pretty pointless to disable/uninstall. |
com.google.ar.core doesn't run on boot.
You know how end-users are like in general. It's always a good idea to be very explicit!
Yeah. That's probably why I don't like them! 🤔
Fair enough
Yeah. You're right. It's pointless. |
Does this mean we're in agreement that theme packages and managers should be put in
Sure, we seem to be in agreement on the rough structure of the definitions, let's discuss specific wording further in the feedback "Issue" post I've been planning to drop after we finish this pull. |
Yes. Go ahead. Thanks again for spending your free time helping me on this project! :)
Good idea. I really want to merge this ASAP. This is a huge pull request and there will be a lot of conflicts to resolve if I commit changes in the main branch before merging it. I don't have much time at the moment but I hope I could resolve the last discussions and merge this by the end of the week. |
Mainly updated removal list for most themes. Also fixed a couple of descriptions mostly related to themes or packages with themes.
There we go, think we're just about done here now. |
I went through most issue requests and added the most obvious ones (that didn't need any/much additional info) to take them off your plate 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one little thing I'll fix right now and we're good to merge!
`com.samsung.android.forest` is the old package name of `com.samsung.android.wellbeing`
Added a bunch of packages from Oneplus 3/3T and Oneplus 9.
Added a bunch of descriptions for packages already in the list.
Corrected some erroneous descriptions.
Shortened some descriptions and corrected some grammar.
Changed "Removal" and "List" for some packages.
To save you some time and give a taste of my changes, here's some highlights from the list (all of these lacked descriptions or were very wrong):
com.android.carrierdefaultapp
com.android.ons - Opportunistic Network Service
com.oneplus.orm
com.oneplus.screenrecord - Screen Recorder
com.qualcomm.qti.smq - QTR (Qualcomm Technology Reporting)
Image of activity (obviously can't be included in the list, but figured I'd show it here on Github):
net.oneplus.launcher - Oneplus Launcher
com.google.android.apps.work.oobconfig - Device Setup
com.qualcomm.qti.smq nicely illustrates how useful Activity Launcher can be in combination with a Package Viewer that shows Activities.
As you saw in one of the new list entries; I've found a way to see running system processes. The Simple System Monitor app with the PACKAGE_USAGE_STATS permission (granted through ADB) is the only way I've found in Android 11.
Seeing running system processes also showed some interesting things, like some processes running even while disabled(I assume Uninstall would yield the same result). For example com.qualcomm.location and Dolby & Dirac Sound System services run even if disabled, with RAM usage. I guess some system packages(com.oneplus.orm) rely on access to user-space(which disable/uninstall removes) while others(qualcomm.location/audio systems) don't and run just like normal even when disabled/uninstalled?
My changes have been over the course of a couple of weeks, but I've taken care to include any changes in recent commits, so nothing should be lost and it should merge nicely with the main branch.