Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow "topic_prefix" to be defined for the MQTT broker #41

Closed
freefd opened this issue May 3, 2024 · 4 comments
Closed

Feature: Allow "topic_prefix" to be defined for the MQTT broker #41

freefd opened this issue May 3, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@freefd
Copy link
Contributor

freefd commented May 3, 2024

Intro:
First of all, thanks a ton for such a useful tool that helps not to invent some weird overengineered integrations just to get notifications from the Frigate.

The original Frigate implementation allows to override the MQTT topic prefix: https://github.com/blakeblackshear/frigate/blob/dev/docs/docs/configuration/reference.md?plain=1#L22-L24.

However, the code is currently fixed to the default topic name: https://github.com/0x2142/frigate-notify/blob/main/events/mqtt.go#L127.

Is it possible to relax this and allow the users to define their own topic_prefix through configuration, with the fallback to the "frigate"?

Thank you.

@0x2142 0x2142 self-assigned this May 3, 2024
@0x2142 0x2142 added the enhancement New feature or request label May 3, 2024
@0x2142
Copy link
Owner

0x2142 commented May 3, 2024

Hey there! Thanks for using this project & I appreciate your feedback! 😊

I can definitely add that in as a config parameter. I'll keep you updated once it's in!

@0x2142 0x2142 added this to the v0.2.7 milestone May 3, 2024
0x2142 added a commit that referenced this issue May 6, 2024
Allow changing default MQTT topic prefix via config (#41)
@0x2142
Copy link
Owner

0x2142 commented May 6, 2024

Hello - Just letting you know this was added in the latest release: v0.2.7. Docs for this are here

@freefd
Copy link
Contributor Author

freefd commented May 6, 2024

Hi @0x2142, thanks a lot, I've already checked the code, looks fantastic!

Itm, I think we can close this issue then.

@0x2142
Copy link
Owner

0x2142 commented May 6, 2024

Perfect. Thanks for the quick feedback! I'll close the issue for now 👍

@0x2142 0x2142 closed this as completed May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants