revert(tls): Revert tls_built_in_root_certs option #105
Conversation
WalkthroughThe changes made involve simplifying the configuration options for TLS within the Rust HTTP/WebSocket client. Notably, the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ClientBuilder
participant Config
User->>ClientBuilder: Create a new client
ClientBuilder->>Config: Set up configuration
Config-->>ClientBuilder: Configuration ready
User->>ClientBuilder: Build the client
ClientBuilder->>User: Return configured client
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- Cargo.toml (1 hunks)
- src/async_impl/client.rs (3 hunks)
- src/blocking/client.rs (1 hunks)
- src/tls/extension.rs (1 hunks)
- tests/badssl.rs (1 hunks)
Files skipped from review due to trivial changes (3)
- Cargo.toml
- src/tls/extension.rs
- tests/badssl.rs
Additional comments not posted (2)
src/blocking/client.rs (1)
Line range hint
1-1:
Verify impact oftls_built_in_root_certsremoval.The method
tls_built_in_root_certswas removed fromClientBuilder. Ensure that this removal does not cause issues in other parts of the codebase that might rely on this method.Verification successful
No Impact from
tls_built_in_root_certsRemovalThe method
tls_built_in_root_certsis not referenced elsewhere in the codebase, including comments and documentation. Its removal does not cause any issues.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the removal of `tls_built_in_root_certs` does not cause issues elsewhere in the codebase. # Test: Search for any references to `tls_built_in_root_certs`. Expect: No references found. rg --type rust 'tls_built_in_root_certs'Length of output: 40
Script:
#!/bin/bash # Search for `tls_built_in_root_certs` in comments or documentation files. rg 'tls_built_in_root_certs' --type md --type toml --type yaml --type json # Search for `tls_built_in_root_certs` in Rust comments. rg '//.*tls_built_in_root_certs' --type rust # Search for any test files that might have referenced `tls_built_in_root_certs`. rg 'tls_built_in_root_certs' --type rust --type testLength of output: 203
Script:
#!/bin/bash # Re-run the search for `tls_built_in_root_certs` in Rust files, which may include test files. rg 'tls_built_in_root_certs' --type rustLength of output: 40
src/async_impl/client.rs (1)
Line range hint
1-1:
Verify impact oftls_built_in_root_certsremoval.The
tls_built_in_root_certsfield and associated method were removed fromConfigandClientBuilder. Ensure that this removal does not cause issues in other parts of the codebase that might rely on this configuration.
Summary by CodeRabbit
New Features
Bug Fixes
tls_built_in_root_certsoption from the ClientBuilder for both async and blocking clients, streamlining TLS configuration.Tests
test_badssl_no_built_in_rootstest function, reflecting updated testing strategy for TLS configurations.