-
-
Notifications
You must be signed in to change notification settings - Fork 18
feat(client): Add impersonate_with_headers
allows optionally setting request headers
#127
Conversation
…g request headers
…g request headers
Warning Rate limit exceeded@0x676e67 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 5 minutes and 1 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThis update introduces enhancements to an asynchronous Rust application, enabling the use of HTTP client impersonation through customizable headers. A new method, Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- examples/impersonate_with_headers.rs (1 hunks)
- src/client/client.rs (2 hunks)
Additional comments not posted (4)
examples/impersonate_with_headers.rs (1)
1-18
: Example Code Approved.The example demonstrates the use of
impersonate_with_headers
effectively and appears correct. It provides a clear and concise demonstration of the new functionality.src/client/client.rs (3)
267-268
: Change Approved:impersonate
method update.The
impersonate
method now correctly delegates toimpersonate_with_headers
withset_headers
set totrue
, maintaining backward compatibility.
270-281
: New Method Approved:impersonate_with_headers
.The
impersonate_with_headers
method is a well-implemented addition that provides conditional header management, enhancing flexibility in client configuration.
297-308
: Modification Approved:apply_tls_settings
method.The addition of the
set_headers
parameter toapply_tls_settings
allows for conditional header application, which is implemented correctly and enhances the method's flexibility.
…g request headers
…g request headers
…g request headers
Summary by CodeRabbit