Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse error domains containing xn-- #1126

Closed
Maka0 opened this issue Sep 2, 2023 · 1 comment · Fixed by #1131
Closed

Parse error domains containing xn-- #1126

Maka0 opened this issue Sep 2, 2023 · 1 comment · Fixed by #1131
Assignees
Labels
🐞 bug Something isn't working
Milestone

Comments

@Maka0
Copy link

Maka0 commented Sep 2, 2023

Upgraded to 0.22 (skipped 0.21 due to the parsing rework) but now the parsing of blocklist fail when it finds domains containing xn--. For example using blocklist https://big.oisd.nl/regex the following errors are shown:

[2023-09-02 16:45:58]  WARN list_cache: parse error: line 2592: 2 errors occurred:
	* idna: invalid label "aptslabs-6fd\\": /^(.*\.)?2023\.xn--aptslabs-6fd\.net$/
	* invalid ip: /^(.*\.)?2023\.xn--aptslabs-6fd\.net$/

, trying to continue count=2580 source=https://big.oisd.nl/regex
[2023-09-02 16:45:59]  WARN list_cache: parse error: line 13224: 2 errors occurred:
	* idna: invalid label "futuroenespaol-1nb\\": /^(.*\.)?adbmetrics\.xn--futuroenespaol-1nb\.es$/
	* invalid ip: /^(.*\.)?adbmetrics\.xn--futuroenespaol-1nb\.es$/

, trying to continue count=13211 source=https://big.oisd.nl/regex
[2023-09-02 16:46:00]  WARN list_cache: parse error: line 33199: 2 errors occurred:
	* idna: invalid label "55qx5d\\": /^(.*\.)?autodiscover\.xn--55qx5d\.cn$/
	* invalid ip: /^(.*\.)?autodiscover\.xn--55qx5d\.cn$/

, trying to continue count=33185 source=https://big.oisd.nl/regex
[2023-09-02 16:46:00]  WARN list_cache: parse error: line 33200: 2 errors occurred:
	* idna: invalid label "90amc\\": /^(.*\.)?autodiscover\.xn--90amc\.xn--p1acf$/
	* invalid ip: /^(.*\.)?autodiscover\.xn--90amc\.xn--p1acf$/

, trying to continue count=33185 source=https://big.oisd.nl/regex
[2023-09-02 16:46:00]  WARN list_cache: parse error: line 33201: 2 errors occurred:
	* idna: invalid label "gnstigbestellen-zvb\\": /^(.*\.)?autodiscover\.xn--gnstigbestellen-zvb\.de$/
	* invalid ip: /^(.*\.)?autodiscover\.xn--gnstigbestellen-zvb\.de$/

, trying to continue count=33185 source=https://big.oisd.nl/regex

@0xERR0R 0xERR0R self-assigned this Sep 7, 2023
@0xERR0R 0xERR0R added the 🐞 bug Something isn't working label Sep 7, 2023
@0xERR0R 0xERR0R added this to the v0.23 milestone Sep 7, 2023
@0xERR0R
Copy link
Owner

0xERR0R commented Sep 7, 2023

I can reproduce this error. We're trying to convert the hostname from puny code to ASCII, even if it is a regex. I changed this behavior: regex will not be converted. @ThinkChaos please check, if it is ok :)

0xERR0R added a commit that referenced this issue Sep 8, 2023
* fix: don't convert regex from punycode to ASCII (#1126)

* chore(test): add additional tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants