Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blocky exits with status 0 (success) even when it fails at startup #1165

Closed
bjornfor opened this issue Sep 20, 2023 · 1 comment · Fixed by #1166
Closed

blocky exits with status 0 (success) even when it fails at startup #1165

bjornfor opened this issue Sep 20, 2023 · 1 comment · Fixed by #1166
Assignees
Labels
🐞 bug Something isn't working
Milestone

Comments

@bjornfor
Copy link

bjornfor commented Sep 20, 2023

I noticed this when the listening port was already taken:

$ blocky --config /path/to/config.yaml
[...]
[2023-09-20 11:55:23]  INFO server: Starting server
[2023-09-20 11:55:23]  INFO server: http server is up and running on addr/port 4000
[2023-09-20 11:55:23] ERROR server start failed: start tcp listener failed: listen tcp :53: bind: address already in use
$ echo $?
0

I think blocky should exit with non-zero status in this case. That should signal the error to systemd, unlike now where systemd thinks the exited blocky process is completely fine/expected.

blocky version: 0.21

EDIT: Pasted wrong log -- this one shows the address already in use error.

@bjornfor
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants