Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] config maxErrorsPerFile is missing from documents #1289

Closed
shizunge opened this issue Dec 3, 2023 · 4 comments
Closed

[Doc] config maxErrorsPerFile is missing from documents #1289

shizunge opened this issue Dec 3, 2023 · 4 comments
Assignees
Labels
📙 documentation Improvements or additions to documentation

Comments

@shizunge
Copy link
Contributor

shizunge commented Dec 3, 2023

In the 0.22 Release, #986 added maxErrorsPerFile.

This config is missing from document https://0xerr0r.github.io/blocky/v0.22/configuration/
and the example config file https://0xerr0r.github.io/blocky/v0.22/config.yml

@ThinkChaos ThinkChaos added 🐞 bug Something isn't working 📙 documentation Improvements or additions to documentation labels Dec 3, 2023
@ThinkChaos ThinkChaos self-assigned this Dec 3, 2023
@shizunge
Copy link
Contributor Author

shizunge commented Dec 3, 2023

Is that same as maxErrorsPerSource? Or they are different configs?

@ThinkChaos
Copy link
Collaborator

Yes maxErrorsPerSource is the newer version that means the same.
Where did you find the maxErrorsPerFile mention so I can update it?

@shizunge
Copy link
Contributor Author

shizunge commented Dec 4, 2023

I only saw maxErrorsPerFile in the release note. I did not search the codes.

I searched issues and PR, but I did not find anything related to change maxErrorsPerFile to maxErrorsPerSource

@ThinkChaos
Copy link
Collaborator

It was renamed in #998 so it could be re-used by the hosts file resolver.

I'll go ahead and close this since the docs are up to date and using the old option should still work (with a warning) thanks to the migration.

@ThinkChaos ThinkChaos removed the 🐞 bug Something isn't working label Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📙 documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants