-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add maxErrorsPerFile blocking configuration #986
Conversation
The default max errors per file of 5 is too small IMHO. This commit makes this number user-configurable.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #986 +/- ##
==========================================
+ Coverage 93.47% 93.61% +0.13%
==========================================
Files 63 63
Lines 5320 5323 +3
==========================================
+ Hits 4973 4983 +10
+ Misses 271 266 -5
+ Partials 76 74 -2
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Looks good to me. 👍 I'll approve it after the linter errors are fixed. |
0d84bf6
to
b1ffea9
Compare
Thanks for the PR! I pushed a couple commits to fix the lint error, add docs and a test, and allow using -1 as the value for "no limit". FYI we also want to support percentage and switch the default to that, see #966. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- linter ok 👍
- documentation enhanced 👍
- unit test coverage 👍
The change to disable the error limit sounds reasonable since it's already an internal constant.
Awesome, thanks! |
The default max errors per file of 5 is too small IMHO. This commit makes this number user-configurable.