Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite DNS response cache #378

Closed
0xERR0R opened this issue Dec 22, 2021 · 2 comments · Fixed by #413
Closed

Rewrite DNS response cache #378

0xERR0R opened this issue Dec 22, 2021 · 2 comments · Fixed by #413
Assignees
Labels
🔨 enhancement New feature or request 🧰 technical debts Technical debts, refactoring
Milestone

Comments

@0xERR0R
Copy link
Owner

0xERR0R commented Dec 22, 2021

Current implementation has some drawbacks:

New implementation should be created:

  • Cache with limited element size (max elements)
  • LRU
  • TTL support
  • callback function before entry is expired, which allows to refresh the entry and set new TTL
@0xERR0R 0xERR0R self-assigned this Dec 22, 2021
@0xERR0R 0xERR0R added the 🔨 enhancement New feature or request label Dec 22, 2021
@0xERR0R 0xERR0R added this to the 0.18 milestone Dec 22, 2021
@0xERR0R 0xERR0R added the 🧰 technical debts Technical debts, refactoring label Dec 22, 2021
0xERR0R added a commit that referenced this issue Jan 16, 2022
0xERR0R added a commit that referenced this issue Jan 17, 2022
0xERR0R added a commit that referenced this issue Jan 17, 2022
0xERR0R added a commit that referenced this issue Jan 18, 2022
0xERR0R added a commit that referenced this issue Jan 19, 2022
@kwitsch
Copy link
Collaborator

kwitsch commented Feb 25, 2022

Bench tested 0.17 vs 0.18 resolution time of cached DNS entries.

Results:
0.17: ~15ms
0.18: ~6ms

For testing purpose i deployed the different versions on the same docker host with and identical configuration.
Each version was tested with DNS-Bench & DNS Test(Android App).

I'm positively impressed.
Great job. 👍

@0xERR0R
Copy link
Owner Author

0xERR0R commented Feb 26, 2022

Hi, that is cool. My goal was to remove the forked implementation of not maintained project. If the new implementation is also faster - this is a double win👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 enhancement New feature or request 🧰 technical debts Technical debts, refactoring
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants