Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Support for redis sentinel #632

Closed
onedr0p opened this issue Aug 18, 2022 · 2 comments · Fixed by #757
Closed

[Feature]: Support for redis sentinel #632

onedr0p opened this issue Aug 18, 2022 · 2 comments · Fixed by #757
Assignees
@kwitsch
Labels
🔨 enhancement New feature or request
Milestone
v0.21

Comments

@onedr0p
Copy link
Contributor

onedr0p commented Aug 18, 2022

Hi 👋🏼

It would be great if blocky could connect to a highly available redis instance.

Here's a couple examples of applications that support this method of redis.

https://www.authelia.com/configuration/session/redis/
https://github.com/outline/outline/blob/93bb9d067d0f61a2f5d6f1d302774b128095a4d0/.env.sample#L22L29

Thanks!
@kwitsch
Copy link
Collaborator

kwitsch commented Aug 21, 2022

Looks reasonable to me.
Will work on it as I get some time.

@0xERR0R 0xERR0R mentioned this issue Aug 21, 2022
Closed
@0xERR0R 0xERR0R added the 🔨 enhancement New feature or request label Aug 21, 2022
@kwitsch kwitsch self-assigned this Aug 22, 2022
@0xERR0R 0xERR0R added this to the future milestone Nov 4, 2022
@kwitsch kwitsch mentioned this issue Nov 9, 2022
Closed
@kwitsch kwitsch mentioned this issue Nov 19, 2022
Merged
@0xERR0R 0xERR0R modified the milestones: future, 0.21 Nov 21, 2022
0xERR0R added a commit that referenced this issue Nov 24, 2022
@kwitsch @0xERR0R
feat: Support for redis sentinel(#632)
c19d4bd 
Co-authored-by: Dimitri Herzog <dimitri.herzog@gmail.com>
@onedr0p
Copy link
Contributor Author

onedr0p commented Nov 24, 2022

Thanks! This makes blocky more resilient to failure if a redis master goes offline. Much appreciated 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kwitsch kwitsch

Labels
🔨 enhancement New feature or request
Projects
None yet
Milestone
v0.21
Development

Successfully merging a pull request may close this issue.

[Feature]: Support for redis sentinel(#632) kwitsch/blocky-dev
3 participants
@onedr0p @kwitsch @0xERR0R